feat: add multiple classes conditionning #628
Open
+57
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beniz This PR is not ready, I have several questions about the integration of multiple class in joligen:
cls_semantic_nclasses
seems to be used only by GAN models, for diffusion, class conditioning uses thef_s_semantic_nclasses
parameter. Should we usecls_semantic_nclasses
instead? cc @royaletrain_config
, since*_semantic_nclasses
is now an array instead of an int