Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Block Constructors #185

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Block Constructors #185

wants to merge 3 commits into from

Conversation

amberpixels
Copy link
Contributor

@amberpixels amberpixels commented Dec 20, 2024 •
edited
Loading

  1. Fixes Why isn't BasicBlock autofilled for each type? #173 : Adds constructors for all blocks
  2. Fixes Need an BlockTypeAudio type #183: Adds missing const BlockTypeAudio (as a constant for consistency)
  3. Changes are on top of BlockTypeTableBlock -> BlockTypeTable; BlockTypeTableRowBlock -> Bloc… #186

@amberpixels amberpixels mentioned this pull request Dec 20, 2024
Open
@amberpixels amberpixels force-pushed the feature/173-block-constructors branch from e4c3b10 to ed3dcef Compare December 20, 2024 21:11
@amberpixels
Copy link
Contributor Author

amberpixels commented Dec 21, 2024 •
edited
Loading

P.S. Here I'd better wait for #187 to be merged, and then I'll remove my fixes for BlockTypeAudio as there in !187 changes are more complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need an BlockTypeAudio type Why isn't BasicBlock autofilled for each type?
1 participant
@amberpixels