Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert supported >= 3.22 #3320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chandrabezzo
Copy link

I see in the pubspec.yaml file supported from Flutter SDK >= 3.22. But, the code just supported on Flutter SDK >= 3.29. Need to reverted then make relevan changes in the future with updated the pubspec.yaml. I think projects that use 3.29 still limited need to support for others dependencies upgrade to the latest gradle. Better to support 3.22 for now.

@chandrabezzo chandrabezzo changed the title Revert supported 3.22 Revert supported >= 3.22 Feb 24, 2025
@chandrabezzo chandrabezzo changed the base branch from master to latest-getx5-RC February 25, 2025 07:19
@chandrabezzo chandrabezzo changed the base branch from latest-getx5-RC to master February 25, 2025 07:19
@jonataslaw
Copy link
Owner

Is your proposal that I release two more versions?
One with this change, supporting the new SDK, and then another reverting it, and removing the deprecated code by adding a new SDK constraint?

@chandrabezzo
Copy link
Author

HI @jonataslaw thanks for response, have you check your latest master pubspec.yaml? You set min version of flutter SDK support is 3.22. But, if we run with getx version get 5.0.0-release-candidate-9.3.2 using 3.22 is impossible because have several code (method) that just supported on the latest Flutter SDK >= 3.29.

You have two choice, update your pubspec.yaml with 3.29 as minimum, or reverted the code that just supported in 3.29 on this pull request I've created.

I think for now better to supported projects that supported with minimum 3.22 instead of force minimum version on 3.29. Have you see this article? We need to support others packages or plugins to use 3.29 as our minimum Flutter SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants