-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a system for tooltips #237
Draft
NancokPS2
wants to merge
6
commits into
jonathaneeckhout:main
Choose a base branch
from
NancokPS2:tooltip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancokPS2
changed the title
Adds a system for interactive tooltips
Adds a system for ~interactive~ tooltips
Feb 11, 2024
NancokPS2
changed the title
Adds a system for ~interactive~ tooltips
Adds a system for tooltips
Feb 11, 2024
var closest_dir_to_border: PopupDirections | ||
var smallest_value: float = INF | ||
|
||
print(direction_dist_dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This print should probably be removed
Testing:
Issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is surprisingly difficult to find the position of text without direct access to TextSever RIDs (i tried for 3 days). So this will probably get reworked with Godot 4.3 which adds a method to do it for you.
This tooltip is a Node2D that when added to any Control node, will automatically display a tooltip in the direction opposite to the closest edge of the screen (can be forced to be a set direction) with text set on the Tooltip node.
It will use the parent's theme if it has any and no theme was defined on the tooltip yet.
It also supports "sub tooltips" which cause yet another tooltip to spring from the original when a keyword is hovered with the mouse, explaining in further detail said keyword.Sub tooltips have been delayed until Godot 4.3
Tooltips can be "pinned" which prevents them from moving or dissapearing by pressing the middle mouse button by default.
Added tooltips to some stats in the stats menu, the shop UI and the shortcuts at the top left of the screen.
TODO: