Fix Issue #1802 (CD audio code re-port) and Grand Theft Auto installer #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1802 pointed out some issue(s) exist in the CD audio code, ported previously from dosbox-staging. On the other hand, I noticed that the DOSBox ECE's CD audio code works fine, so I decided to re-port the relevant code (including SDL_Sound) from DOSBox ECE instead. As a result, the CD track should no longer stops while playing in game, and MP3/OGG/FLAC tracks will still be supported.
I also fixed the issue with the Grand Theft Auto installer which may get stuck with "COMMAND" shown in the titlebar when trying to re-install the game to the same directory, as mentioned in Issue #1809.