-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track OrgLimits data on Log__c #646
Conversation
…om the class System.OrgLimits
…with 'real' field section headers
… filtering on records that have a value populated in Log__c.OrganizationLimits__c
…izationLimits__c and display it in a page section, similar to how the LogEntry__c formula fields for transaction limits are displayed
…nLimits, to control if transaction limits are retrieved from the class System.Limits & stored on LogEntry__c Previously, transaction limits were always populated, with no way to disable it - using the Limits class does seem to have some overheaded, so being able to disable this functionality can, hilariously, help with limits
…e default values (true) for 'StoreOrganizationLimits' and 'StoreTransactionLimits'
@jamessimone following up on your comment about
The 1 flaky test failure seems a little suspicious, but I haven't been able to reproduce it. Do you remember if you were seeing a specific error message before when you tried to use |
@jongpie let me take a look, at the time I was able to repro the issue with a synchronous test run |
It seems to work now, great call! |
@jamessimone awesome, thanks for checking! |
14e1aea
to
46c7bd9
Compare
… avoid flappy test results
9f0394b
to
77982ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 95.03% 95.05% +0.01%
==========================================
Files 50 50
Lines 5624 5663 +39
==========================================
+ Hits 5345 5383 +38
- Misses 279 280 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Core Unlocked Package Changes
Resolved Capture OrgLimits data on Log__c #630 by adding new functionality to track organization limits data, returned by the class
System.OrgLimits
This data is automatically stored as JSON in the new field
Log__c.OrganizationLimits__c
You can disable storing this data, using the new
LoggerParameter__mdt
recordStoreOrganizationLimits
This data is displayed within a new "Organization Limits" tab on the
Log__c
flexipage, using a new LWClogOrganizationLimits
(shown below). The design of this LWC is intended to mimic the existing formula fields shown onLogEntry__c
that are used to track transaction limits.For comparison, this image shows the existing formula fields on
LogEntry__c
that are used to track transaction limits.Added another new
LoggerParameter__mdt
record,StoreTransactionLimits
, to control if transaction limits are retrieved from the classSystem.Limits
& stored onLogEntry__c
System.Limits
class does seem to have some overhead (namely, it uses CPU time), so being able to disable this functionality can, hilariously, help to reduce transaction limits usage.loggerPageSection
LWC changes: Fixed some padding inloggerPageSection.html
so it's more consistent with 'real' field section headers