Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Comments__c Field on LoggerParameter__mdt #650

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Mar 13, 2024

  • Added new field LoggerParameter__mdt.Comments__c as a place for admins & developers to store notes about why a LoggerParameter__mdt record has been customized.

    • This is only intended for documentation purposes to help admins viewing the record in the org, as well as a way to document customizations in git/VCS

    image

  • Updated LoggerParameter__mdt records to include the XML node for the new Comments__c field

  • Scope creep: added missing project license info in several LWC files

  • Scope creep: added .npmrc file to explicitly set the npm registry

jongpie added 5 commits March 13, 2024 15:07
…s & developers to store notes about why a LoggerParameter__mdt record has been customized

This is only intended for documentation purposes to help admins viewing the record in the org, as well as a way to document customizations in git/VCS
@jongpie jongpie added Type: Enhancement New feature or request Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type labels Mar 13, 2024
@jongpie jongpie temporarily deployed to Base Scratch Org March 13, 2024 21:03 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org March 13, 2024 21:03 — with GitHub Actions Inactive
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (f6b0afc) to head (25827b7).

❗ Current head 25827b7 differs from pull request most recent head dce1766. Consider uploading reports for the commit dce1766 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files          50       50           
  Lines        5669     5669           
=======================================
  Hits         5389     5389           
  Misses        280      280           
Flag Coverage Δ
Apex 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie changed the title Added new Comments__c field on LoggerParameter__mdt Added New Comments__c Field on LoggerParameter__mdt Mar 14, 2024
@jongpie jongpie merged commit b3a08f0 into main Mar 14, 2024
1 check passed
@jongpie jongpie deleted the feature/logger-parameter-comments branch March 14, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants