Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Updated Logger.setAsyncContext() behavior #770

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Sep 25, 2024

Core Unlocked Package Changes

  • Updated the behavior of Logger.setAsyncContext() to only set the context the first time a non-null context value is provided
    • Previously, subsequent calls would overwrite the context value, which wasn't really the intended behavior - it's intended to be used to set context at the beginning of a transaction

Pipeline Changes

  • Made some optimizations in build.yml so some steps don't run on draft PRs

@jongpie jongpie added Type: Bug Something isn't working devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Logging Source: Apex Items related to using Logger within Apex Layer: Logger Engine Items related to the core logging engine labels Sep 25, 2024
@jongpie jongpie temporarily deployed to Advanced Scratch Org September 25, 2024 00:06 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Event Monitoring Scratch Org September 25, 2024 00:06 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to OmniStudio Scratch Org September 25, 2024 00:20 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org September 25, 2024 00:21 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org September 25, 2024 00:27 — with GitHub Actions Inactive
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (1629291) to head (b1830e1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   92.24%   92.25%           
=======================================
  Files          74       74           
  Lines        7211     7216    +5     
  Branches      199      199           
=======================================
+ Hits         6652     6657    +5     
  Misses        531      531           
  Partials       28       28           
Flag Coverage Δ
Apex 94.24% <100.00%> (+<0.01%) ⬆️
LWC 83.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie changed the title Bugfix: updated Logger.setAsyncContext() behavior Bugfix: Updated Logger.setAsyncContext() behavior Sep 25, 2024
@jongpie jongpie merged commit ab92cd5 into main Sep 25, 2024
1 check passed
@jongpie jongpie deleted the bugfix/improved-set-async-context-logic branch September 25, 2024 01:25
@jamessimone
Copy link
Collaborator

Aw yeah!

@jongpie
Copy link
Owner Author

jongpie commented Sep 25, 2024

@jamessimone thanks again for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Layer: Logger Engine Items related to the core logging engine Logging Source: Apex Items related to using Logger within Apex Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants