-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing hashbrown drain APIs for Map and Set #19
Conversation
Hmm guess tarpaulin is compiling tests with rustc < 1.52.0? |
Hmm, I didn't think tarpaulin was using an old compiler..
|
I'm not sure I'd have to look at the tool attributes and CI jobs, but I can say tarpaulin just uses the version of the compiler installed in the system as it calls out to the process. So either the rust version used in the tests is old or there's something else afoot 🤔 . I raised an issue in tarpaulin and I'll try to have a deeper look this week |
So, this is specifically running with the Docker image (specifically |
Okay that will be the latest stable compiler (at time the image was built) then |
That's weird though, as the latest stable compiler should support |
@jonhoo latest hadn't been updated since 1.51.0, a new |
Codecov Report
|
That seems to have done it, thanks! @pedromfedricci Just the change from the comment left now and then I think we're 👍 |
Hey! @jonhoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thank you!
Co-authored-by: rtkay123 <[email protected]>
Related to #4 - "The Drain iterators".