Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

haiksu
Copy link

@haiksu haiksu commented Apr 26, 2023

This pull request adds keyboard navigation possibility to the block. The user can navigate to the progress bar and visit the activity by tabbing to it and pressing the enter key.

image

@haiksu
Copy link
Author

haiksu commented Apr 26, 2023

The issue reference (#1) doesn't match (as I developed this originally in gitlab).

@jonof
Copy link
Owner

jonof commented Jun 28, 2023

Which is worse: no keyboard navigation, or the finger-trap created by this change for bars having many dozens of cells which you need tab through each and every one to get past?

@haiksu
Copy link
Author

haiksu commented Jun 30, 2023

I understand your perspective. Thank you for your response! Initially, this change was necessitated by a group of our customers who must adhere to more stringent accessibility requirements. In this case the missing keyboard navigation was a deal breaker.

@jonof
Copy link
Owner

jonof commented Jun 30, 2023

My general thoughts are have the 'tab' key get you on and off the bar (important for the Overview page), perhaps focusing the first visible cell, and then pressing left/right arrow keys moves between adjacent cells. However, I haven't had the time to spend prototyping the idea to find all the cases where that won't work.

@haiksu
Copy link
Author

haiksu commented Jun 30, 2023

Sounds good. Thanks for testing the pull request anyway! I'll see if I can find time to improve the request (after the summer holiday).

@seh-notts
Copy link

I understand your perspective. Thank you for your response! Initially, this change was necessitated by a group of our customers who must adhere to more stringent accessibility requirements. In this case the missing keyboard navigation was a deal breaker.

Hi @haiksu We are a UK University and have the same stringent accessibility requirements. If there is anything I can do to help progress the development please do let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants