[4.0] Group toolbar buttons [com-content -> articles] #21247

ciar4n · 2018-07-24T13:28:10Z

Pull Request for Issue joomla/40-backend-template#348 .

Summary of Changes

Groups com_content -> articles toolbar buttons

Credit to @asika32764 for adding #19670

Testing Instructions

Apply PR and navigate to com_content -> articles.

Before PR

After PR

Documentation Changes Required

Yes

brianteeman

approve new language string

brianteeman · 2018-07-24T13:33:54Z

This loses the work that @Fedik did to disable buttons

ciar4n · 2018-07-24T13:36:32Z

@brianteeman Would you have the number on that PR?

ciar4n · 2018-07-24T13:37:23Z

Any suggestions for the 'Change Status' icon and color?

brianteeman · 2018-07-24T13:42:30Z

I think the pr was #20650

You will need to get the a11y team to review this so that the dropdown is described and announced correctly

ciar4n · 2018-07-24T13:45:30Z

You will need to get the a11y team to review this so that the dropdown is described and announced correctly

@joomla/joomla-accessibility-team-jat Please review.

ghost · 2018-07-24T13:47:17Z

I have tested this item ✅ successfully on 47fc7c1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21247.}

ciar4n · 2018-07-24T13:54:05Z

This loses the work that @Fedik did to disable buttons

@Fedik As JS is not really my forte, I'll ask you for some guidance on this.

chmst · 2018-07-24T14:03:10Z

I would like to remember my PR and show only buttons if they can do someting . https://issues.joomla.org/tracker/joomla-cms/20559

dgrammatiko · 2018-07-24T14:32:09Z

@ciar4n are you using Bootstrap's dropdown here?

ghost · 2018-07-24T14:34:18Z

@chmst

show only buttons if they can do someting

+1

ciar4n · 2018-07-24T14:52:10Z

@ciar4n are you using Bootstrap's dropdown here?

Yes. I think doing anything else is outside of the scope of this PR. For now lets consider that grouping buttons is the way to go and if so, how best to group them,

brianteeman · 2018-07-24T15:01:29Z

no - lets wait a year for a custom element - that solves everything everywhere

dgrammatiko · 2018-07-25T11:55:48Z

@brianteeman you know what I'll revert all the custom elements work. Back to jQuery bootstrap seems what people want! So let me please you and good luck with Joomla 4...

wilsonge · 2018-07-25T22:21:54Z

Please stop fighting. Ciaran is correct that this is not the place for the custom elements discussion - he's using the api for grouping buttons. Whether that uses Bootstrap or Custom Elements is a totally different issue/PR. (To an extent so is the accessibility of that dropdown as it's not just going to be used here - but across many extensions for differing groupings - although of course if we can sort that here all the better!).

However ensuring that we don't regress the grey'ing out of buttons when no items are selected is important and should be considered as part of this issue

Fedik · 2018-07-26T06:58:31Z

the question here, what should be "grayed" (disabled), the "main" button of the group, or the elements in it?

the elements not grayed, because in the group they are "anchors" <a> not <button>, if I right remember,
I try to check more next weekend

brianteeman · 2018-07-26T08:35:36Z

@Fedik As none of the "change status" options will be enabled unless an item is selected then I would suggest that it should be the main button that is disabled

chmst · 2018-07-26T21:23:32Z

My2Cent: The graying needs a designer. As it is now, I always try to clean my glasses. Maybe gray could be really gray?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21247.}

brianteeman · 2018-07-26T21:36:12Z

Or even grey 😂

ghazal · 2018-07-27T10:24:51Z

I have tested this item ✅ successfully on 47fc7c1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21247.}

ghost · 2018-07-27T10:40:00Z

Ready to Commit after two successful tests.

wilsonge · 2018-07-27T11:27:05Z

Please remove the RTC as per discussions above here #21247 (comment) it is not ready to be merged yet

ciar4n · 2018-08-14T16:39:39Z

@wilsonge if you can merge this, i can look at doing similar in other views

wilsonge · 2018-08-14T22:13:40Z

templates/system/incompatible.html

@@ -6,7 +6,7 @@
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Joomla: unsupported PHP version</title><!-- Sets the page title, IMPORTANT DO NOT REMOVE -->
  <style>body{margin:0;padding:0;font:14px / 18px sans-serif;color:#555;background-color:transparent}html{background:#f1f1f1;background:-moz-radial-gradient(center,ellipse cover,rgba(241,241,241,1) 0,rgba(58,146,200,1) 100%);background:-webkit-radial-gradient(center,ellipse cover,rgba(241,241,241,1) 0,rgba(58,146,200,1) 100%);background:radial-gradient(ellipse at center,rgba(241,241,241,1) 0,rgba(58,146,200,1) 100%);background-repeat:no-repeat;background-attachment:fixed}ol,ul{padding:0;margin:0;list-style:none}a{color:#0084b4;text-decoration:none;outline:0}a:hover,a:focus{text-decoration:underline}p a{line-height:inherit}.container{display:flex;flex-direction:column;justify-content:center;align-items:center;position:relative;margin:0 auto;width:100%;height:100vh;overflow:hidden}.alert-main{display:block;position:relative;background:#fff;border:1px solid rgba(0,0,0,0.1);border-radius:5px;padding:20px 60px;margin:0 20px;box-shadow:0 0 10px rgba(0,0,0,0.05)}svg{position:absolute;bottom:-120px;right:-70px;width:400px;transform:rotate(10deg);z-index:-1}h1,p{position:relative;z-index:10;text-align:center;text-rendering:optimizeLegibility}h1{margin:18px 0 0;font-size:40px;font-weight:200;line-height:1;text-shadow:0 1px 2px rgba(0,0,0,.2)}p,label{margin:10px 0 20px;font-size:18px;font-weight:300;line-height:25px;color:#777}p a{font-weight:bold;color:#1c3d5c}.link-help{padding:.4rem .85rem;font-size:1rem;font-weight:normal;border-radius:.25rem;text-decoration:none;background-color:#f5f5f5;border:1px solid rgba(0,0,0,0.1)}.link-help:hover{background-color:#eee;text-decoration:none}.footer{margin:8px 20px;text-align:left;font-size:11px}.footer ul{margin-bottom:5px}.footer li{display:inline;margin:0 5px;line-height:20px}.footer li,.footer a{color:#1c3d5c}.footer a:hover{color:#59b0ff}.links{display:block;text-align:center;margin-top:4rem;margin-left:auto;margin-right:auto;font-size:1rem}.links li{display:inline-block;margin-top:20px}@media screen and (max-width:480px){.container{height:auto;padding-top:20px;padding-bottom:20px}h1{font-size:30px}.link-help{white-space:nowrap}}</style><!-- Sets the page styling, IMPORTANT DO NOT REMOVE -->
-  <script>window.errorLocale = {"en-GB":{"language":"English GB","header":"Sorry, your PHP version is not supported","text1":"Your host needs to use PHP version {{phpversion}} or newer to run this version of Joomla","help-url-text":"Help me resolve this"},"en-US":{"language":"English US","header":"Sorry, your PHP version is not supported","text1":"Your host needs to use PHP version {{phpversion}} or newer to run this version of Joomla","help-url-text":"Help me resolve this"},}</script><!-- Sets the content of the translated text, IMPORTANT DO NOT REMOVE -->
+  <script>window.errorLocale = {"c:\xampp\htdocs\joomla-4-dev\installation\language\en-GB\en-GB":{"language":"English GB","header":"Sorry, your PHP version is not supported","text1":"Your host needs to use PHP version {{phpversion}} or newer to run this version of Joomla","help-url-text":"Help me resolve this"},"c:\xampp\htdocs\joomla-4-dev\installation\language\en-US\en-US":{"language":"English US","header":"Sorry, your PHP version is not supported","text1":"Your host needs to use PHP version {{phpversion}} or newer to run this version of Joomla","help-url-text":"Help me resolve this"},}</script><!-- Sets the content of the translated text, IMPORTANT DO NOT REMOVE -->


@dgrammatiko this looks like a windows build issue if i ever saw one :D

@ciar4n can you test if https://github.com/joomla/joomla-cms/compare/4.0-dev...dgrammatiko:es6/4.0-dev/fix-build-tools?expand=1 fixes this dos problem?

wilsonge · 2018-08-14T22:14:03Z

libraries/src/MVC/Model/AdminModel.php

@@ -928,7 +928,7 @@ public function getItem($pk = null)

 		// Convert to the CMSObject before adding other data.
 		$properties = $table->getProperties(1);
-		$item = ArrayHelper::toObject($properties, CMSObject::class);
+		$item = ArrayHelper::toObject($properties, 'CMSObject');


Can we leave this one as it was before please

wilsonge · 2018-08-14T22:21:11Z

@rdeutz is the system test here failing because we're moving the basic toolbar to a webcomponent or some other reason?

wilsonge · 2018-08-14T22:22:19Z

Definitely want to get this merged. Need Dimitris to fix the installation stuff (you can manually patch you versions for now in both installation files), fix the merge conflict you accidentally committed and I've asked Robert to look into the system test failure because that's not the 'normal' installation one that fails from time to time

dgrammatiko · 2018-08-15T00:22:30Z

fix the installation stuff

What's broken?

infograf768 · 2018-08-15T05:27:50Z

Question: is this still compatible with the WORKFLOW?
(Just compared the test instructions screenshot with what we have now with workflow.)

Please post a screenshot of what is now expected from this PR, specially the Status dropdown.

infograf768 · 2018-08-15T05:30:47Z

Also, can't apply here (with eclipse) the changes brought to cassiopea

infograf768 · 2018-08-15T05:39:13Z

After patching I confirm that using the "Change Status" toolbar button is useless except for Feature/Unfeature.

ciar4n · 2018-08-15T07:38:35Z

Question: is this still compatible with the WORKFLOW?

Honestly no idea. All I get when opening 'workflow' is...

I'd have presumed it was a different component so doesn't apply here. I guess that must be incorrect. Also add that this PR was created prior to workflow been merged.

Also, can't apply here (with eclipse) the changes brought to cassiopea

What changes exactly?

After patching I confirm that using the "Change Status" toolbar button is useless except for Feature/Unfeature.

I assume this is in the 'workflow' component?

infograf768 · 2018-08-15T07:43:00Z

I assume this is in the 'workflow' component?

Nope. It is in the Articles Manager where the new workflow stuff has impact.

Since workflow has been merged, quite a few things have disapeared from the time when you created this PR. Basically, we have, in Articles Manager, a totally different use of the Toolbar.

infograf768 · 2018-08-15T07:44:46Z

Here is what we get now without your patch:

ciar4n · 2018-08-15T08:01:12Z

Here is what we get now without your patch:

~~Certainly not what I am seeing on this end. I think I might have to park this until workflows is more stable.~~

ciar4n · 2018-08-15T09:49:36Z

After patching I confirm that using the "Change Status" toolbar button is useless except for Feature/Unfeature.

With workflows introduced, this is indeed true. I have no idea how to go about fixing this.

ciar4n · 2018-08-17T13:33:31Z

So it appears workflow removes the publish/unpublish/archive/trash buttons from the toolbar? I guess that leaves feature/unfeatured the only items added to the 'Change Status' dropdown?

brianteeman · 2018-08-17T14:40:50Z

and that is just plain wrong and hopefully it will be changed

houndci-bot · 2018-08-17T14:50:06Z

administrator/templates/atum/scss/blocks/_toolbar.scss

+    &[disabled],
+    &.dropdown-toggle[disabled] {
+      background-color: $gray-600;
+      border-color: $gray-600


Declaration should be terminated by a semicolon

…oolbar-articles

ciar4n · 2018-08-17T14:57:10Z

This PR contains the required CSS to apply similar changes to other views. So for the sake of moving things along, only the feature/unfeatured options remain in the toolbar (as is currently the case). They can be added back when ready by does working on workflows.

This PR should be once again ready for testing/merging

bembelimen · 2018-08-17T22:09:27Z

I really like this PR, perhaps we could implement a in some way "intelligent" dropdown button, which offers transitions depending on the selected articles...

The good thing is, with this approach we would get, although we're using the new workflow, exactly this output, when using the unmodified default workflow: https://user-images.githubusercontent.com/2803503/43141243-6266f50c-8f4d-11e8-8d8a-a80a96bf4127.png

coolcat-creations · 2018-09-08T09:50:38Z

If it could look like #22004 designwise it would be great.

ciar4n · 2018-10-09T15:14:30Z

Closing. Replaced by #22393.

Group toolbar buttons [com-content -> articles]

47fc7c1

ciar4n requested a review from brianteeman as a code owner July 24, 2018 13:28

joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jul 24, 2018

brianteeman approved these changes Jul 24, 2018

View reviewed changes

joomla-cms-bot removed Language Change This is for Translators PR-4.0-dev labels Jul 27, 2018

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 27, 2018

laoneo added this to the Joomla 4.0 milestone Jul 27, 2018

wilsonge reviewed Aug 14, 2018

View reviewed changes

fixes

91cff1a

ciar4n added 2 commits August 17, 2018 15:45

Remove publish/trash/archive

c257e72

Set border color to disabled button

00d2207

houndci-bot reviewed Aug 17, 2018

View reviewed changes

ciar4n added 2 commits August 17, 2018 15:50

happy hound

15f1fab

Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into t…

cbb71ea

…oolbar-articles

ggppdk mentioned this pull request Aug 19, 2018

[4.0] [RFC] [Workflow] About re-adding (multi-record) buttons to toolbar based on available workflow transitions #21708

Closed

Fedik mentioned this pull request Sep 4, 2018

[4.0] [Backend Template] Content - Manage - Articles - Actionbutton #436 #22004

Closed

bembelimen mentioned this pull request Sep 26, 2018

[4.0] Workflow article buttons #22393

Merged

ciar4n closed this Oct 9, 2018

[4.0] Group toolbar buttons [com-content -> articles] #21247

[4.0] Group toolbar buttons [com-content -> articles] #21247

Conversation

ciar4n commented Jul 24, 2018 • edited by joomla-cms-bot Loading

Summary of Changes

Testing Instructions

Before PR

After PR

Documentation Changes Required

brianteeman left a comment

Choose a reason for hiding this comment

brianteeman commented Jul 24, 2018

ciar4n commented Jul 24, 2018

ciar4n commented Jul 24, 2018

brianteeman commented Jul 24, 2018

ciar4n commented Jul 24, 2018

ghost commented Jul 24, 2018

ciar4n commented Jul 24, 2018

chmst commented Jul 24, 2018

dgrammatiko commented Jul 24, 2018

ghost commented Jul 24, 2018

ciar4n commented Jul 24, 2018

brianteeman commented Jul 24, 2018

dgrammatiko commented Jul 25, 2018

wilsonge commented Jul 25, 2018

Fedik commented Jul 26, 2018

brianteeman commented Jul 26, 2018

chmst commented Jul 26, 2018

brianteeman commented Jul 26, 2018

ghazal commented Jul 27, 2018

ghost commented Jul 27, 2018

wilsonge commented Jul 27, 2018

ciar4n commented Aug 14, 2018

wilsonge Aug 14, 2018

Choose a reason for hiding this comment

dgrammatiko Aug 15, 2018

Choose a reason for hiding this comment

wilsonge Aug 14, 2018

Choose a reason for hiding this comment

wilsonge commented Aug 14, 2018

wilsonge commented Aug 14, 2018

dgrammatiko commented Aug 15, 2018

infograf768 commented Aug 15, 2018

infograf768 commented Aug 15, 2018

infograf768 commented Aug 15, 2018

ciar4n commented Aug 15, 2018

infograf768 commented Aug 15, 2018 • edited Loading

infograf768 commented Aug 15, 2018

ciar4n commented Aug 15, 2018 • edited Loading

ciar4n commented Aug 15, 2018

ciar4n commented Aug 17, 2018

brianteeman commented Aug 17, 2018

houndci-bot Aug 17, 2018

Choose a reason for hiding this comment

ciar4n commented Aug 17, 2018

bembelimen commented Aug 17, 2018

coolcat-creations commented Sep 8, 2018

ciar4n commented Oct 9, 2018

ciar4n commented Jul 24, 2018 •

edited by joomla-cms-bot

Loading

infograf768 commented Aug 15, 2018 •

edited

Loading

ciar4n commented Aug 15, 2018 •

edited

Loading