-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3]Sort order of fields relative to their actual location in the table #44486
Open
brianteeman
wants to merge
4
commits into
joomla:5.3-dev
Choose a base branch
from
brianteeman:workflow2
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
I have tested this item ✅ successfully on d44ec3c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486. |
I have tested this item ✅ successfully on d44ec3c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486. |
Signed-off-by: BrianTeeman <[email protected]>
@Quy @Kostelano I forgot to do the same for the featured articles list - please can you additionally test that |
I have tested this item ✅ successfully on d223bd3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486. |
1 similar comment
I have tested this item ✅ successfully on d223bd3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #34501 .
Summary of Changes
in the element sorting field on the page, the STAGE field is at the very bottom, however, I remember exactly that we previously saved the order in this field relative to the actual location in the table (in this case, the stage line should be the second after ORDERING).
This pull request includes changes to the workflow-related sorting options in the content management system. The changes ensure that these options are only available when the workflow feature is enabled AND that they are positioned in the filter in the correct position
Workflow-related sorting options:
administrator/components/com_content/forms/filter_articles.xml
: Added new sorting optionsJSTAGE_ASC
andJSTAGE_DESC
that require the workflow feature to be enabled.Conditional form field handling:
administrator/components/com_content/src/Model/ArticlesModel.php
: Removed the addition of workflow-related sorting options within thegetFilterForm
method when the workflow feature is enabled, as this is now handled directly in the form definition.Conditional option inclusion:
libraries/src/Form/Field/ListField.php
: Added a check to exclude options that require the workflow feature if the workflow feature is not enabled.Testing Instructions
Using Sample Data
Test 1. Enable workflows and observe in the sort filter dropdown the position of Stage Asc/Desc in the list
Test 2. Disable Workflows and observe that Stage Asc/Desc is not present in the list
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed