Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Add the js-grid-item-is-checked class and remove onClick HtmlHelper Grid #44501

Draft
wants to merge 2 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

LadySolveig
Copy link
Contributor

@LadySolveig LadySolveig commented Nov 21, 2024

Pull Request for Issue # .

Summary of Changes

This PR adds the js-grid-item-is-checked class and remove onClick in the HtmlHelper for Grid as it was originally prepared in the script.

target.querySelectorAll('.js-grid-item-is-checked').forEach((element) => element.addEventListener('click', applyIsChecked));

Testing Instructions

  • (optional) install sample data
  • go to articles list view
  • try out if you can mark single articles bei checkbox and by clicking on the row
  • try out if you can mark multiple articles
  • try out if you can select and deselect all articles
  • try if you can mark articles and use the batch processes

Install this PR
Do the same again.

Actual result BEFORE applying this Pull Request

All should work.

Expected result AFTER applying this Pull Request

All should work as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig LadySolveig marked this pull request as ready for review November 21, 2024 13:55
@Quy
Copy link
Contributor

Quy commented Nov 21, 2024

I have tested this item ✅ successfully on 5b16e75


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44501.

@dgrammatiko
Copy link
Contributor

FWIW I had to revert this some time ago as it broke 3rd PD code: #40192
But would be cool to have CSP strict OOTB at some point

@LadySolveig LadySolveig marked this pull request as draft November 22, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants