Fix joomlaExtButtons TinyMCE plugin, buttons validation #44507
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
Fedik
changed the title
|
I have tested this item ✅ successfully on 2d2529c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44507. |
1 similar comment
|
I have tested this item ✅ successfully on 2d2529c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44507. |
joomla-cms-bot
removed
NPM Resource Changed
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44507. |
alikon
added
NPM Resource Changed
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
TinyMCE prints a warning about incorect value for joomlaExtButtons, when all buttons is disabled.
The PR is fixing it, by allowing the empty array of buttons.
Testing Instructions
run
npm installEdit
joomla-cms/administrator/components/com_content/forms/article.xml
Line 57 in a0982cf
and set
buttons="false"Open Browser Dev console, and open any article for editing.
Actual result BEFORE applying this Pull Request
Console warning: Invalid value passed for the joomlaExtButtons option. The value must be a object.
Expected result AFTER applying this Pull Request
No warning
Link to documentations
Please select: