Feature: Switch to a SharedFlow for network status #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintain backwards compatibility by introducing a new property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the network Flow is backed by a
StateFlowwhich requires a default value. This default value is set toDisconnected. This was a design flaw since it doesn't reflect the actual state of the network.Instead a new property
statusUpdateshas been added that is backed by aSharedFlow. This means there will only be updates once the state is actually known.Connectivity.updateshas been deprecated and will be replaced withstatusUpdatesin the future, since theConnectivity.Updateis flawed.