refactor: Added an extra check for manualCollectionName to the 'Plex-…

… Available in amount of other collections' rule. This fixes a potential nullpointer
jorenn92 · Jan 28, 2024 · 3990fa8 · 3990fa8
1 parent 493a3ea
commit 3990fa8
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/server/src/modules/rules/getter/plex-getter.service.ts b/server/src/modules/rules/getter/plex-getter.service.ts
@@ -95,12 +95,27 @@ export class PlexGetterService {
           return item.Label ? item.Label.map((l) => l.tag) : [];
         }
         case 'collections': {
-          // fetch metadata because collections in plexLibrary object are wrong
           return metadata.Collection
             ? metadata.Collection.filter(
                 (el) =>
                   el.tag.toLowerCase().trim() !==
-                  (ruleGroup?.collection?.manualCollection
+                  (ruleGroup?.collection?.manualCollection &&
+                  ruleGroup?.collection?.manualCollectionName
+                    ? ruleGroup.collection.manualCollectionName
+                    : ruleGroup.name
+                  )
+                    .toLowerCase()
+                    .trim(),
+              ).length
+            : 0;
+        }
+        case 'collection_tags': {
+          return metadata.Collection
+            ? metadata.Collection.filter(
+                (el) =>
+                  el.tag.toLowerCase().trim() !==
+                  (ruleGroup?.collection?.manualCollection &&
+                  ruleGroup?.collection?.manualCollectionName
                     ? ruleGroup.collection.manualCollectionName
                     : ruleGroup.name
                   )