-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add "Original Language" rule to Sonarr & Radarr #1407
Conversation
It looks like there is a problem with the server, if you don't manually choose it. Even with it set as the default server. I made a rule but if I didn't click on the server dropdown and select something, a server wasn't set in the rule. Same for Sonarr with only one server.
Once I selected a server, it worked as expected. This is also a problem with the Library setting as it always shows Movies, on first creation of a rule, but still shows a Media Type entry option. It won't work if you leave it as those default options, obviously. |
I have another WIP branch to add a None option to the server list so that it can fallback to deleting via Plex for people with content from YouTube. I removed the default server option in there as well as it doesn't really make much sense to default to one, it should be an explicit action the user takes. I'll merge that into this branch and fix any of those remaining issues. |
419f647
to
2df5907
Compare
@ydkmlt84 Give this latest commit a try. You now have to select a library & server instead of it defaulting to something EDIT: I still need to make the 'None' server action work. Or maybe I'll do that in a separate PR and remove the option here for now. |
/release-pr |
Released to |
2df5907
to
439cf9f
Compare
Actually this already works, I missed the existing code that already handles this. When the 'None' option is selected we'll attempt to delete the media via Plex. If you have Allow media deletion turned off in Plex, then you should see an error being logged when it attempts to delete. At least from that you can tell that it's attempting to so fulfils the requirement. |
439cf9f
to
8c55142
Compare
/release-pr |
Released to |
/release-pr |
Released to |
The array was being accessed by index instead of the ID. Radarr props index & id do not align due to skipping id 1.
- also remove the default server option for *arr settings as this is no longer used.
bf777b1
to
e664850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I like the changes to library and server selections! Thanks again for helping with the project!!
For feature request: https://features.maintainerr.info/posts/52/allow-to-filter-based-on-the-original-language-value-in-sonarr
I've fixed the Radarr & Sonarr server selection not persisting on initial rule creation. I've also fixed an exception/logic error when checking the cacheReset flag.