Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "Original Language" rule to Sonarr & Radarr #1407

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

benscobie
Copy link
Collaborator

For feature request: https://features.maintainerr.info/posts/52/allow-to-filter-based-on-the-original-language-value-in-sonarr

I've fixed the Radarr & Sonarr server selection not persisting on initial rule creation. I've also fixed an exception/logic error when checking the cacheReset flag.

@ydkmlt84
Copy link
Collaborator

ydkmlt84 commented Dec 2, 2024

It looks like there is a problem with the server, if you don't manually choose it. Even with it set as the default server.

I made a rule but if I didn't click on the server dropdown and select something, a server wasn't set in the rule. Same for Sonarr with only one server.

[maintainerr] | 02/12/2024 14:38:44  [ERROR] [RadarrGetterService] No Radarr server configured for testing language
[maintainerr] | 02/12/2024 14:39:58  [INFO] [RulesService] A crucial setting of Rulegroup 'testing language' was changed. Removed all media & specific exclusions
[maintainerr] | 02/12/2024 14:39:58  [INFO] [RulesService] Successfully updated rulegroup 'testing language'.
[maintainerr] | 02/12/2024 14:42:50  [INFO] [CollectionsService] Adding collection to the Database..
[maintainerr] | 02/12/2024 14:43:07  [ERROR] [SonarrGetterService] No Sonarr server configured for testing_TV_language

Once I selected a server, it worked as expected.

This is also a problem with the Library setting as it always shows Movies, on first creation of a rule, but still shows a Media Type entry option. It won't work if you leave it as those default options, obviously.

image

@benscobie
Copy link
Collaborator Author

benscobie commented Dec 3, 2024

I have another WIP branch to add a None option to the server list so that it can fallback to deleting via Plex for people with content from YouTube. I removed the default server option in there as well as it doesn't really make much sense to default to one, it should be an explicit action the user takes. I'll merge that into this branch and fix any of those remaining issues.

@benscobie benscobie force-pushed the feat-original-language branch from 419f647 to 2df5907 Compare December 5, 2024 00:40
@benscobie
Copy link
Collaborator Author

benscobie commented Dec 5, 2024

@ydkmlt84 Give this latest commit a try. You now have to select a library & server instead of it defaulting to something

EDIT: I still need to make the 'None' server action work. Or maybe I'll do that in a separate PR and remove the option here for now.

@benscobie
Copy link
Collaborator Author

/release-pr

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Released to jorenn92/maintainerr:pr-1407 🚀

@benscobie benscobie force-pushed the feat-original-language branch from 2df5907 to 439cf9f Compare December 6, 2024 14:57
@benscobie
Copy link
Collaborator Author

benscobie commented Dec 6, 2024

EDIT: I still need to make the 'None' server action work. Or maybe I'll do that in a separate PR and remove the option here for now.

Actually this already works, I missed the existing code that already handles this. When the 'None' option is selected we'll attempt to delete the media via Plex. If you have Allow media deletion turned off in Plex, then you should see an error being logged when it attempts to delete. At least from that you can tell that it's attempting to so fulfils the requirement.

@benscobie benscobie force-pushed the feat-original-language branch from 439cf9f to 8c55142 Compare December 6, 2024 14:58
@benscobie
Copy link
Collaborator Author

/release-pr

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Released to jorenn92/maintainerr:pr-1407 🚀

@benscobie
Copy link
Collaborator Author

/release-pr

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Released to jorenn92/maintainerr:pr-1407 🚀

The array was being accessed by index instead of the ID. Radarr props index & id do not align due to skipping id 1.
- also remove the default server option for *arr settings as this is no longer used.
@benscobie benscobie force-pushed the feat-original-language branch from bf777b1 to e664850 Compare December 15, 2024 23:25
Copy link
Collaborator

@ydkmlt84 ydkmlt84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I like the changes to library and server selections! Thanks again for helping with the project!!

@ydkmlt84 ydkmlt84 merged commit bf6bf49 into main Dec 16, 2024
6 checks passed
@ydkmlt84 ydkmlt84 deleted the feat-original-language branch December 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants