Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not create a supervisord.log file #777

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Conversation

buroa
Copy link
Contributor

@buroa buroa commented Jan 22, 2024

This allows us to mount the root filesystem as read-only.

See here: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/

@jorenn92
Copy link
Owner

Thank you for your contribution!

I suggest redirecting the log file to the /opt/data volume rather than removing it entirely.

@jorenn92
Copy link
Owner

Thank you for your contribution!

I suggest redirecting the log file to the /opt/data volume rather than removing it entirely.

I've pushed this change to your branch. Once the checks are completed, I will proceed with merging it.

@jorenn92 jorenn92 merged commit cd5df98 into jorenn92:main Jan 25, 2024
3 checks passed
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants