This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
Get sh-prefixed commands directly from pyenv #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pyenv-virtualenv support, as the `pyenv` function would not properly call `sh-activiate` and `sh-deactivate`. Also removed an unnecessary recursion into our own function definition.
|
Thanks so much for this! @rsalmei Could you try this out? Might be a fix for what you're running into with #12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes pyenv-virtualenv support, as the
pyenvfunction would not properly callsh-activiateandsh-deactivate.Also removed an unnecessary recursion into our own function definition.