This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
Check interactive mode instead of login shell #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 can we merge that ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12 where pyenv is not being initialized with this plugin.
The current
conf.dscript checks whether it is login shell or not, if so it will then set thePATHvariable.However, it never triggers in my system (I am using Arch) as I think because the fish shell is never used to Start X, even though fish is my default shell. Therefore, line 16-17 never ended up running. This is related to this comment
I have changed the checking from checking if it's login-shell to checking if it's interactive shell, and it fixes the problem.