-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full embedded support #14
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Thank you very much for your effort. This looks very good.
I've left a few minor and easy to fix comments.
It's hard for me to check this and test it myself without building an example project. And it's quite complex what you had to add. Would it be possible for you to also add a simple test case for this? See the Tests/Functional/src
for other tests. Maybe you can easily add one similar to those?
I still have to finish the test. |
I had a test on the existing pass on user ; |
@joschi127 hi ! I'm not sure about this : are my last commits visible to you ? (ones with the fix for the typos and the ones with the tests) |
Here is a first try to overrided embedded property class in the same way as for entities.
In addition to previous PR about light embedded support :
The purpose of this listener is to replace the mappings of fields related to embedded properties.
I had take the assumption that properties of an embeddable class are "simple" and won't be overloaded in the child class.