Updated Pet and Vaccination model classes, integrated vaccination record management, and modified the edit view #365
Conversation
| @@ -191,4 +192,15 @@ private ModelAndView fillPetAndImageUrl(ModelAndView modelAndView) { | |||
| modelAndView.addObject("defaultImage", defaultImage); | |||
| return modelAndView; | |||
| } | |||
|
|
|||
| // Method to view vaccination records for a specific pet | |||
| @GetMapping(value = "/vaccinations/{uuid}") | |||
There was a problem hiding this comment.
You do not need to add another end-point to receive vaccines, because you can add a List<Vaccination> vaccines collection to PetCommand so that you can re-use the same pet/update end-point
| import static jakarta.persistence.GenerationType.IDENTITY; | ||
|
|
||
| import com.josdem.vetlog.enums.PetStatus; | ||
| import jakarta.persistence.CascadeType; |
There was a problem hiding this comment.
Please do not format the code, it makes harder to review your changes, we have spotless plugin to format the code automatically when we run tests, for more information see:
vetlog-spring-boot/build.gradle
Line 124 in 559f732
| @JoinColumn(name = "adopter_id") | ||
| private User adopter; | ||
|
|
||
| @OneToMany(mappedBy = "pet", fetch = FetchType.LAZY, cascade = CascadeType.ALL) // Map to Vaccination |
There was a problem hiding this comment.
I usually avoid to have double relationship, I rely in only one entity definition, please notice we have a relationship defined in Vaccination entity:
| // Relationship mapping to Pet | ||
| @ManyToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "pet_id", nullable = false) | ||
| private Pet pet; |
There was a problem hiding this comment.
Why are you adding an image relationship? This task has nothing to do with images.
| @@ -58,6 +58,6 @@ public class Vaccination { | |||
| private VaccinationStatus status; | |||
|
|
|||
| @ManyToOne(fetch = FetchType.LAZY) | |||
| @JoinColumn(name = "pet_id") | |||
| @JoinColumn(name = "pet_id", nullable = false) // Ensure pet_id is not nullable | |||
|
|
||
| /** |
There was a problem hiding this comment.
We normaly call this overdesign, you do not need to add code beyond the acceptance criteria.
| <tr th:each="vaccination : ${petCommand.vaccinations}"> | ||
| <td th:text="${vaccination.name}"></td> | ||
| <td> | ||
| <select th:field="*{vaccinations[__${vaccination.index}__].status}"> |
There was a problem hiding this comment.
You need to read the current vaccines status value here, I do not think this code will do the job.
No description provided.