Updated rgb #130
Open
Updated rgb #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Updated jumpers with bypass tabs. Solder once for bypassing the section. * Updated footprints with silkscreen for the GND tab on the LEDs. * Cleaned a bunch of tracks, consolidated GND/VCC with consistent width.
|
I'm looking to place an order of PCBs and am not sure of the current state of SK6812 mini-e support for the Sofle-RGB 2.1 Does this PR contain the all of the necessary PCB changes to have a functional, working board now? Or should I go with the PCB in PR#90 and the code changes mentioned by @Cirromulus? |
|
Howdy @climent... I implemented your idea on top of the Thanks! |
|
Yes, I checked and it seems to be correctly implemented. The idea is simply
short the circuit if no LEDs have been added to the "detour". If LED are
added the circuit is complete without the need of closing the jumper.
Thanks for looking into this.
…On Sun, 18 Feb 2024 at 03:25, tiadobatima ***@***.***> wrote:
Howdy @climent <https://github.com/climent>... I implemented your idea on
top of the mini-e LED design (in #90
<#90> ).
For now, it's just in this branch:
https://github.com/tiadobatima/SofleKeyboard/tree/mini-e%2Bbypass
It makes the whole thing so much simpler. Could you do a sanity check on
it, before I open a new PR please?
Thanks!
—
Reply to this email directly, view it on GitHub
<#130 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFHC6GLF3RLWRM3FMD6WZLYUFYA7AVCNFSM5K23DAR2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJVGA4DSMJYG44Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
climent () gmail ! com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described, this PR contains the updated RGB with:
Corrected width on GND/VCC tracks
Updated silkscreen with GND marked for LED in both sides
Removed Jumpers and updated with bypass pads.
I do not expect this to be merged, i just created this PR for visibility and to demonstrate the changes I was playing with.