Fix dynamic cors setting #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cases In my previous attempt here I missed settings the 'Access-Control-Allow-Origin' headers in some cases. I've refactored the options interface to ensure that it is sent in all cases, and added further tests to ensure it is.
|
I'm not using this library for anything (I moved my projects to websockets a few years ago and haven't looked back). Do you want commit & npm publish access so you can fix this stuff yourself? |
|
Yeah that would be great, we are still using this project. EDIT: my npm username is also reem |
|
Great. invite sent, and npm owner added. Merge at your leasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I missed some cases in my last PR! I added new tests
to ensure that cors headers are correctly sent in all cases and
refactored the internal options interface to ensure this sort of
error is now impossible.
Also included is a change to npm test to ensure that it always
runs against the latest coffeescript code.