Replace tokenizer #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the way tests are called for cross platform testing - Added a 'build' package script for running gulp
…nizer - Also fixes joshbtn#83
|
excel-formula-tokenizer approved the pull request so I have updated this branch to use the 3.0 version which passes all tests of both packages |
|
@joshbtn also I have not committed the build files in this but let me know if I should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to remove the formula tokenizer and replace it with the one in excel-formula-tokenizer
This is not ready to go yet as their is still an open pull request on excel-formula-tokenizer psalaets/excel-formula-tokenizer#7 to add the compatibility layer and fix an issue that was already fixed in the original tokenizer