Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(enh) Build for Linux on ARM. #25

Merged
merged 3 commits into from
Jul 9, 2024
Merged

(enh) Build for Linux on ARM. #25

merged 3 commits into from
Jul 9, 2024

Conversation

glennj
Copy link
Collaborator

@glennj glennj commented Jul 3, 2024

cc does not have a -m64 option on ARM

cc does not have a `-m64` option on ARM
@glennj glennj added the enhancement New feature or request label Jul 3, 2024
@glennj
Copy link
Collaborator Author

glennj commented Jul 3, 2024

There's no github workflow for arm. Here's proof:

$ uname -a
Linux exercism-vm 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:46 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

$ python3 util/test.py
(bin/wrenc) Passed: 96 Failed: 0 Skipped: 4 Path

  ✅ should normalize
  ✅ detect root
  ✅ navigate paths
  ✅ join
  ✅ dirname
  ✅ split
  ✅ windows

Tests:  💯 ✓ 7 passed, 7 total

Runtime

  ✅ have class level constants
  ✅ have details
  ✅ assertVersion
  ✅ have capabilities
  ✅ allow querying capabilities

Tests:  💯 ✓ 5 passed, 5 total

All 99 tests passed (275 expectations).
Skipped 3 tests: 
Skipped 1 tests: Windows

@glennj glennj requested a review from joshgoebel July 5, 2024 18:30
@joshgoebel
Copy link
Owner

Does GitHub have a builder for this architecture?

@glennj
Copy link
Collaborator Author

glennj commented Jul 5, 2024

Not for free, it looks like:

In addition to the standard GitHub-hosted runners, GitHub offers customers on GitHub Team and GitHub Enterprise Cloud plans a range of managed virtual machines with advanced features - for example, more cores and disk space, GPU-powered machines, and ARM-powered machines.

https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job

@joshgoebel
Copy link
Owner

So this is all just to remove -m64... does Make have anyway to just detect the architecture or add a conditional so the single makefile would work on any Linux?

@glennj
Copy link
Collaborator Author

glennj commented Jul 9, 2024

@joshgoebel got it. Now only adds the -m64 option on x86_64 machines.

@joshgoebel joshgoebel merged commit 86264af into joshgoebel:main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants