Remove duplicates in final list #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses joshmedeski#156 and removes duplicates based on the Path entries. Performance time is linear wrt number of entries.
|
Also added a flag to list (--hide-duplicates / -d) to control the removal |
joshmedeski
approved these changes
Jan 27, 2025
|
Hang on before merging - I'd like to see if there's a way to make it default on in sesh.toml rather than having to litter -d all over the place. |
|
I don't recommend that @szinn I'd like people to opt-into it for now, in the future we could add something to the config file to allow users to opt-into it always. |
|
But I'm happy with the feature as-is today. We can add the config option as a future optimization. |
|
No way to do it since doesn't appear to allow options yet - merge away! Let me know if there's other tweaks elsewhere! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #156 and removes duplicates based on the Path entries.
Performance time is linear wrt number of entries.