test(dbushelpers): add test for VariantToValue function

joshuar · Dec 13, 2023 · ce7982e · ce7982e
1 parent e4360c0
commit ce7982e
Showing 1 changed file with 24 additions and 19 deletions.
diff --git a/pkg/dbushelpers/dbus_test.go b/pkg/dbushelpers/dbus_test.go
@@ -735,22 +735,27 @@ func TestGetSessionPath(t *testing.T) {
 	}
 }
 
-// func TestVariantToValue(t *testing.T) {
-// 	type args struct {
-// 		variant dbus.Variant
-// 	}
-// 	tests := []struct {
-// 		name string
-// 		args args
-// 		want S
-// 	}{
-// 		// TODO: Add test cases.
-// 	}
-// 	for _, tt := range tests {
-// 		t.Run(tt.name, func(t *testing.T) {
-// 			if got := VariantToValue(tt.args.variant); !reflect.DeepEqual(got, tt.want) {
-// 				t.Errorf("VariantToValue() = %v, want %v", got, tt.want)
-// 			}
-// 		})
-// 	}
-// }
+func TestVariantToValue(t *testing.T) {
+	type args struct {
+		variant dbus.Variant
+	}
+	tests := []struct {
+		name string
+		args args
+		want string
+	}{
+		{
+			name: "string conversion",
+			args: args{variant: dbus.MakeVariant("foo")},
+			want: "foo",
+		},
+		// TODO: Test all possible variant values?
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := VariantToValue[string](tt.args.variant); !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("VariantToValue() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}