fix(backend) Fix potential send to closed channel from pingInterval #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix(backend): share the client.stop channel in pingInterval so that pingInterval will stop when the client is stopped preventing a chance to send to a closed channel on the next ticker interval - fix(backend): Hub no longer closes client channels, because the client will still be open even if a user quits the game -test(game): add expect block around flaky button click - fix(make): remove deprecated `npm install` in e2e/ folder
Closed
Test Results27 tests 27 ✅ 58s ⏱️ Results for commit bdb60ff. |
karlromets
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(backend): share the client.stop channel in pingInterval so that pingInterval will stop when the client is stopped preventing a chance to send to a closed channel on the next ticker interval
fix(backend): Hub no longer closes client channels, because the client will still be open even if a user quits the game
test(game): add expect block around flaky button click
fix(make): remove deprecated
npm installin e2e/ folderFixes: #191