feat(admin): Hiding questions happen automatically between rounds #198
+32
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- automatically hide questions between rounds. Move the button down near the main controls. I believe this is closer UX wise to what our users would want either hosting in person or online.
Test Results27 tests 27 ✅ 55s ⏱️ Results for commit 57b8735. |
karlromets
requested changes
Mar 10, 2025
There was a problem hiding this comment.
It would be good to turn this off for the final round since it doesn't do anything there.
After that, we should add a test in settings.spec.ts to check that the button gets disabled - something like "should block hiding questions in the final round".
Otherwise a banger 👍
| game.settings.hide_questions = !game.settings.hide_questions; | ||
| setGame((prv) => ({ ...prv })); | ||
| send({ action: "data", data: game }); | ||
| }} |
There was a problem hiding this comment.
Suggested change
| }} | |
| }} | |
| disabled={game.is_final_round} |
|
|
||
| let textColor = game.settings.hide_questions ? "text-foreground" : "text-foreground"; | ||
| let buttonColor = game.settings.hide_questions ? "bg-secondary-500" : "bg-secondary-300"; | ||
| let textContent = game.settings.hide_questions ? t("Show questions") : t("Hide questions"); |
There was a problem hiding this comment.
If disabled opacity-50 or something like that to indicate button is unclickable visually as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #195