Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better support for cookies #69

Merged
merged 3 commits into from
May 10, 2022
Merged

feat: better support for cookies #69

merged 3 commits into from
May 10, 2022

Conversation

sehnryr
Copy link
Collaborator

@sehnryr sehnryr commented May 10, 2022

Proposed changes

Better cookies management with the help of a Map like CookieJar and Cookie that will store all the data of the cookies.

Better cookies parsing algorithm.

Should fix #44 and #48.

Type of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • My code follows the Dart coding convention
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary documentation (if appropriate)

Further comments

The algorithm works assuming there will not be any commas in keys or values of a cookie.

@sehnryr sehnryr marked this pull request as ready for review May 10, 2022 12:24
@sehnryr sehnryr merged commit 2fe09df into jossef:master May 10, 2022
@sehnryr sehnryr deleted the improve-cookie-algorithm branch May 10, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookies secure has sticked to next key
1 participant