big code refactor #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add dev dependencies mockito and pretty_assertions
josueBarretogit
changed the title
anyhowseparate decoding tasks from fetching data tasks
…MangadexClient and MockMangadexClient
to ensure when creating directories or files there is no character that might throw error
|
😭 This is NOT a small PR. |
josueBarretogit
changed the title
Closed
josueBarretogit
deleted the
test-failure-on-arch-linux-in-a-clean-chroot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and refactor code so that stuff like #23 doesn't happen again