Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add matching score compute for field declarations #30

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

jpedroh
Copy link
Owner

@jpedroh jpedroh commented Jan 5, 2024

There was an issue while matching Java enums because the field declarations nodes do not match the expected identifier structure. The current solution is to implement a new matching handler to fix this.

Something to be done in the near future, is to find a better way to allow customization of the matching function and not allow leaking these specificities info into the matching algorithms themselves

Copy link

codesandbox bot commented Jan 5, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@jpedroh jpedroh merged commit c3c68f1 into main Jan 5, 2024
4 checks passed
@jpedroh jpedroh deleted the feat-compute-matching-score branch January 6, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant