Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matching): Early return on matching if nodes have different kinds #35

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jpedroh
Copy link
Owner

@jpedroh jpedroh commented Mar 1, 2024

This is a bug that was discovered thanks to running the tool in jdime repository. Basically, the matching algorithm was running even if the nodes have different kinds, which was introducing incorrect behavior in the merge step: leading into trying merging two nodes that have different kinds, which is logically inconsistent.

Copy link

codesandbox bot commented Mar 1, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@coveralls
Copy link

Coverage Status

coverage: 85.646% (+0.03%) from 85.616%
when pulling d1ea830 on fix-early-return-matching
into be11ade on main.

@jpedroh jpedroh merged commit 38ad55b into main Mar 1, 2024
6 checks passed
@jpedroh jpedroh deleted the fix-early-return-matching branch March 1, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants