perf: Use Cow for value in MergedCSTNode #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most scenarios, we don't need to create a new
Stringwhen merging the values of two CSTNodes. More often than not, we simply pick the value from either the left or right node, or, ideally, the values of both nodes are equal to the base. Consequently, creating owned Strings is uncommon, and it would be more efficient to return a reference to the value of one of theCSTNodes.To accommodate this use case, this PR updates the
MergedCSTNodeto useCow<str>instead ofString. This change eliminates unnecessaryto_stringcalls, potentially leading to performance improvements in some scenarios.