feat: Custom Tracking Strategies #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously customizing the tracking strategy required monkey patching core methods such as `Shortener::ShortenedUrl#increment_usage_count`. Some implementations may want to easily configure the URL tracking strategy, or disable it entirely. This commit adds a new configuration option to specify the behaviour, with a default value that does not break existing functionality. The strategy can be configured as follows: ```ruby Shortener.increment_usage_count = ->(url) do MyBackgroundJob.perform_later(url) end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! Thanks for making an awesome library!
I recently ran into a use case where it would be convenient to introduce an alternate strategy when updating the
use_countcolumn. In particular, the goal was to move the write database operation out of the request lifecycle into a background job.Previously this customization would require a monkey patch of the
Shortener::ShortenedUrl#increment_usage_countmethod (similar the approach taken in #170).This PR adds a new configuration option to make it simple to specify the tracking behaviour. The option default doesn't break existing functionality, and operates as follows:
Happy to hear any feedback or suggestions, but it seems like this could be a useful addition to the library. Thanks!