Skip to content

Commit

Permalink
Merge pull request #132 from ceball/cleanup
Browse files Browse the repository at this point in the history
Clean up: remove code accidentally not removed in #127
  • Loading branch information
vidartf authored May 21, 2020
2 parents 8c62cd1 + 72dc2f9 commit dfc2be2
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions nbcelltests/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,6 @@ def writeout_test(fp, cells, kernel_name):
fp.write(INDENT * 2 + 'self.run_test(%d)\n' % i)


def writeout_lines_per_cell(fp, lines_per_cell, metadata):
if lines_per_cell:
for i, lines_in_cell in enumerate(metadata.get('cell_lines', [])):
fp.write(INDENT + 'def test_lines_per_cell_%d(self):\n' % i)
fp.write(2 * INDENT + 'assert {lines_in_cell} <= {limit}\n\n'.format(limit=lines_per_cell, lines_in_cell=lines_in_cell))


def writeout_cell_coverage(fp, cell_coverage, metadata):
if cell_coverage:
fp.write(INDENT + 'def test_cell_coverage(self):\n')
Expand All @@ -131,10 +124,6 @@ def run(notebook, rules=None, filename=None):
with open(name, 'w', encoding='utf-8') as fp:
writeout_test(fp, cells, kernel_name)

if 'lines_per_cell' in extra_metadata:
lines_per_cell = extra_metadata.get('lines_per_cell', -1)
writeout_lines_per_cell(fp, lines_per_cell, extra_metadata)

if 'cell_coverage' in extra_metadata:
cell_coverage = extra_metadata['cell_coverage']
writeout_cell_coverage(fp, cell_coverage, extra_metadata)
Expand Down

0 comments on commit dfc2be2

Please sign in to comment.