-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Celltest always generated for non-empty code cell, and always runs; defaults to %cell if test is empty #172
Celltest always generated for non-empty code cell, and always runs; defaults to %cell if test is empty #172
Conversation
@vidartf I have requested a review even though there's a not-yet-done to-do item (that just relates to nbval's handling of bad magics). Meanwhile the other changes and questions are ready for review. |
@vidartf I have made this not be WIP - I have removed the nbval change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't fine-comb it, but it LGTM!
We might revisit some things here, but I agree we should merge. |
Fixes #169, i.e. implements what is described in the opening comment there.
The important changes are in nbcelltets.tests_vendored - the rest is test updates.
Questions:
# no %cell
. Vidar proposed# nbcelltest-skip
. Or even possibly go straight to Allow notebook authors to control cell skipping/mocking other than by comments in code? #171? (I'd rather try the current underlying behavior out for a bit, then if we are keeping it, use a better mechanism than comment.)test_cell_3
method (as opposed to not generating/skipping) when no explicit test has been supplied for cell 3, and hence the test defaults to%cell
. (This is "case 3 from Proposal for when cells/tests should execute #169.) I think we need some people to try it out in lab etc and give feedback one way or the other.# note: there is a test at this cell!
in your notebook, and have test code?To do:
Upstream equivalent nbval fix for bad magics (not how it's done here)filed an issue/started a PR/it's not related to this PRAlso: