build: fix insecure RUNPATH #3212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Dec 2, 2024
Closes: https://bugs.gentoo.org/945698 Fixes: df24c1f Upstream-PR: jqlang/jq#3212 Signed-off-by: orbea <[email protected]>
4 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Dec 3, 2024
[sam: Add revbump.] Closes: https://bugs.gentoo.org/945698 Fixes: df24c1f Upstream-PR: jqlang/jq#3212 Signed-off-by: orbea <[email protected]> Closes: #39565 Signed-off-by: Sam James <[email protected]>
|
@orbea Sorry, I'm trying to catch up the issue but I can't understand well. Could you explain the issue and why we have to remove the flag? |
In Gentoo -static-libtool-libs causes a QA Notice. * QA Notice: The following files contain insecure RUNPATHs * Please file a bug about this at https://bugs.gentoo.org/ * with the maintainer of the package. * /var/tmp/portage/app-misc/jq-1.7.1/image/usr/bin/jqn RPATH: /var/tmp/portage/app-misc/jq-1.7.1/work/jq-jq-1.7.1/.libs Gentoo-Issue: https://bugs.gentoo.org/945698 Signed-off-by: orbea <[email protected]>
|
The |
|
Was added in 5d9ec83 unclear why. Seem ok to me to remove. I wonder if we should have a CI test that verify that the resulting binary actually is static? inspect the binary or maybe run the binary in a scratch container etc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gentoo -static-libtool-libs causes a QA Notice.
Gentoo-Issue: https://bugs.gentoo.org/945698