Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-matched optional capture group should be null and offset -1 #3238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wader
Copy link
Member

@wader wader commented Jan 26, 2025

Fixes #3093

@wader wader force-pushed the match-non-matched-optional-group branch from 55ff8b8 to 728bb0e Compare January 26, 2025 15:30
Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itchyny itchyny requested a review from emanuele6 January 28, 2025 13:31
@itchyny itchyny added this to the 1.8 release milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

capture returns inconsistent results for optional named group
2 participants