Style Guide: Initial commit of SCSS style guide #112
Conversation
| @@ -0,0 +1,123 @@ | |||
| <script>{ | |||
| "title": "Chassis SCSS Style Guide" | |||
| }</script> | |||
There was a problem hiding this comment.
This does nothing unless we either move this to contribute.jquery.org or start using a jquery-wp-content website. Either way in this repo it should be removed.
|
We use css-comb on our scss files so you should mention that all scss should pass css combo and give the settings we use since its not just a preset. https://github.com/jquery/css-chassis/blob/master/.csscomb.json |
|
Since this is chassis specific we should say that variables should never be defined directly in the scss they should always use a seperate js file and explain how this works a bit |
| 4. regular styles | ||
| - Sort declarations based on type such as padding/margin, position/top/right/bottom/left etc. | ||
| 5. pseudo classes and elements | ||
| 6. media queries |
There was a problem hiding this comment.
From what i'v always seen it seems like general convention is to put media queries last
|
@kristyjy Please let me know if I can help you out here. I have made the changes as suggested by @arschmitz to this guide. |
This is a pretty rough first draft but definitely want feedback on what I have so far. Also please let me know if I didn't include something that should be here.