Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem I'm interested in you've probably seen before
`centroidal momentum A, wrenches G
momentum constraints
variables
equality constraint
inequality constraint
LS ρ damping objective
So I wanted to add ρ which can change on a per frame basis to the qp vars. I called something like this VariableVars.
It does require updateVariableVars() to be called before solve()
solver.updateVariableVars(mbs); solver.solve(mbs, mbcs);
I haven't finished my momentum constraints yet, and so only tested for a single multibody plus a rand nr of LS damping VariableVars.
But I wondered what you thought of this in general?
Another question I have is why constraints don't have the same sort of begin() that tasks do i.e. why we write whole lines to the constraint matrices rather than blocks like with Q?
Also included a small fix for PostureTask, where dof and params got mixed up.