Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jdbc_overrides.rb #5

Closed
wants to merge 1 commit into from

Conversation

HarlemSquirrel
Copy link

Same as #4

@headius
Copy link
Member

headius commented May 20, 2020

Ping @enebo @rdubya is this good to go?

@rdubya
Copy link
Collaborator

rdubya commented May 20, 2020

Sorry, I'm crazy busy right now. I need to get the tests running again but I'm wondering what made this start happening since I'm fairly certain that call was required to get tests to pass previously. Is it using a newer version of the mssql driver or something?

@HarlemSquirrel
Copy link
Author

@headius @rdubya @enebo is there any way I can help test this out to move a release along? Thanks!

@rdubya
Copy link
Collaborator

rdubya commented Jul 28, 2020

Sorry, I haven't had any time to look at this. Is this happening because of a newer version of the mssql driver or something?

@rdubya
Copy link
Collaborator

rdubya commented Jul 28, 2020

Just realized that I still haven't gotten a 5.2 compatible version released yet :( so this PR doesn't matter as much as #4 I'd like to know why it suddenly broke though, should we be limiting the versions of the mssql driver that we are compatible with?

@HarlemSquirrel
Copy link
Author

I wish I had more knowledge of mssql. We have one database and we use two tables so it's light.

@HarlemSquirrel
Copy link
Author

For what it's worth, I've been using this driver from my branch with rails 5.2 in production for a few months now with no problem. Just one model and table on that app.

@rdubya
Copy link
Collaborator

rdubya commented Dec 14, 2020

We're implementing a change to deal with the JDBC driver include as mentioned here: #4

So I'm going to close this PR. Thank you for bringing it to our attention and putting in the effort to find a solution.

@rdubya rdubya closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants