Refactor and arity-split Point#mul

jruby · Jun 11, 2024 · 23ff684 · 23ff684
1 parent dd59f74
commit 23ff684
Showing 1 changed file with 58 additions and 53 deletions.
diff --git a/src/main/java/org/jruby/ext/openssl/PKeyEC.java b/src/main/java/org/jruby/ext/openssl/PKeyEC.java
@@ -1099,74 +1099,64 @@ public IRubyObject add(final ThreadContext context, final IRubyObject other) {
             return result;
         }
 
-        @JRubyMethod(name = "mul", required = 1, optional = 2)
-        public IRubyObject mul(final ThreadContext context, final IRubyObject[] args) {
+        @JRubyMethod(name = "mul")
+        public IRubyObject mul(final ThreadContext context, final IRubyObject bn1) {
             Ruby runtime = context.runtime;
 
-            org.bouncycastle.math.ec.ECPoint pointSelf, pointResult;
-
-            Group groupV = this.group;
+            if (bn1 instanceof RubyArray) {
+                throw runtime.newNotImplementedError("calling #mul with arrays is not supported by this OpenSSL version");
+            }
 
-            Point result;
+            org.bouncycastle.math.ec.ECPoint pointSelf;
 
-            BigInteger bn_g = null;
+            Group groupV = this.group;
 
-            ECCurve selfCurve = EC5Util.convertCurve(group.getCurve());
+            ECCurve selfCurve = EC5Util.convertCurve(groupV.getCurve());
             pointSelf = EC5Util.convertPoint(selfCurve, asECPoint());
 
-            result = new Point(runtime, getMetaClass());
-            result.initialize(context, groupV);
-            ECCurve resultCurve = EC5Util.convertCurve(result.group.getCurve());
-            pointResult = EC5Util.convertPoint(resultCurve, result.point);
+            BigInteger bn = getBigInteger(context, bn1);
 
-            int argc = Arity.checkArgumentCount(runtime, args, 1, 3);
-            IRubyObject arg1 = null, arg2 = null;
-            switch (argc) {
-                case 2:
-                    arg2 = args[1];
-                case 1:
-                    arg1 = args[0];
+            org.bouncycastle.math.ec.ECPoint mulPoint = ECAlgorithms.referenceMultiply(pointSelf, bn);
+            if (mulPoint == null) {
+                throw newECError(runtime, "bad multiply result");
             }
-            if (!(arg1 instanceof RubyArray)) {
-                BigInteger bn;
-                if (arg1 instanceof RubyFixnum) {
-                    bn = BigInteger.valueOf(arg1.convertToInteger().getLongValue());
-                } else if (arg1 instanceof RubyBignum) {
-                    bn = ((RubyBignum) arg1).getValue();
-                } else if (arg1 instanceof BN) {
-                    bn = ((BN) arg1).getValue();
-                } else {
-                    throw runtime.newTypeError(arg1, runtime.getInteger());
-                }
 
-                if (arg2 != null) {
-                    if (arg2 instanceof RubyFixnum) {
-                        bn_g = BigInteger.valueOf(arg2.convertToInteger().getLongValue());
-                    } else if (arg2 instanceof RubyBignum) {
-                        bn_g = ((RubyBignum) arg2).getValue();
-                    } else if (arg2 instanceof BN) {
-                        bn_g = ((BN) arg2).getValue();
-                    } else {
-                        throw runtime.newTypeError(arg2, runtime.getInteger());
-                    }
-                }
+            return new Point(runtime, EC5Util.convertPoint(mulPoint), groupV);
+        }
 
-                if (bn_g == null) {
-                    org.bouncycastle.math.ec.ECPoint mulPoint = ECAlgorithms.referenceMultiply(pointSelf, bn);
-                    result = new Point(runtime, EC5Util.convertPoint(mulPoint), result.group);
-                } else {
-                    org.bouncycastle.math.ec.ECPoint mulPoint = ECAlgorithms.sumOfTwoMultiplies(pointResult, bn_g, pointSelf, bn);
-                    result = new Point(runtime, EC5Util.convertPoint(mulPoint), result.group);
-                }
+        @JRubyMethod(name = "mul")
+        public IRubyObject mul(final ThreadContext context, final IRubyObject bn1, final IRubyObject bn2) {
+            Ruby runtime = context.runtime;
 
-                if (result == null) {
-                    newECError(runtime, "bad multiply result");
-                }
-            } else {
+            if (bn1 instanceof RubyArray) {
                 throw runtime.newNotImplementedError("calling #mul with arrays is not supported by this OpenSSL version");
             }
 
-            return result;
+            org.bouncycastle.math.ec.ECPoint pointSelf, pointResult;
+
+            Group groupV = this.group;
+
+            ECCurve selfCurve = EC5Util.convertCurve(groupV.getCurve());
+            pointSelf = EC5Util.convertPoint(selfCurve, asECPoint());
+
+            ECCurve resultCurve = EC5Util.convertCurve(groupV.getCurve());
+            pointResult = EC5Util.convertPoint(resultCurve, ((Point) groupV.generator(context)).asECPoint());
+
+            BigInteger bn = getBigInteger(context, bn1);
+            BigInteger bn_g = getBigInteger(context, bn2);
+
+            org.bouncycastle.math.ec.ECPoint mulPoint = ECAlgorithms.sumOfTwoMultiplies(pointResult, bn_g, pointSelf, bn);
+
+            if (mulPoint == null) {
+                throw newECError(runtime, "bad multiply result");
+            }
+
+            return new Point(runtime, EC5Util.convertPoint(mulPoint), groupV);
+        }
+
+        @JRubyMethod(name = "mul")
+        public IRubyObject mul(final ThreadContext context, final IRubyObject bns, final IRubyObject points, final IRubyObject bn2) {
+            throw context.runtime.newNotImplementedError("calling #mul with arrays is not supported by this OpenSSL version");
         }
 
         @Deprecated
@@ -1185,6 +1175,21 @@ public IRubyObject initialize(final ThreadContext context, final IRubyObject[] a
 
     }
 
+    private static BigInteger getBigInteger(ThreadContext context, IRubyObject arg1) {
+        BigInteger bn;
+        if (arg1 instanceof RubyFixnum) {
+            bn = BigInteger.valueOf(arg1.convertToInteger().getLongValue());
+        } else if (arg1 instanceof RubyBignum) {
+            bn = ((RubyBignum) arg1).getValue();
+        } else if (arg1 instanceof BN) {
+            bn = ((BN) arg1).getValue();
+        } else {
+            Ruby runtime = context.runtime;
+            throw runtime.newTypeError(arg1, runtime.getInteger());
+        }
+        return bn;
+    }
+
     static byte[] encode(final ECPublicKey pubKey) {
         return encodeUncompressed(pubKey.getParams().getOrder().bitLength(), pubKey.getW());
     }