[refactor] simplify - extra checks not needed

jruby · Oct 30, 2024 · 3f64852 · 3f64852
1 parent 377e27a
commit 3f64852
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/org/jruby/ext/openssl/PKeyEC.java b/src/main/java/org/jruby/ext/openssl/PKeyEC.java
@@ -258,7 +258,7 @@ public IRubyObject initialize(final ThreadContext context, final IRubyObject[] a
         final RubyString str = readInitArg(context, arg);
         final String strJava = str.toString();
 
-        if (!strJava.isEmpty() && isCurveName(strJava)) {
+        if (isCurveName(strJava)) {
             this.curveName = strJava;
             return this;
         }
@@ -349,8 +349,9 @@ else if ( key instanceof ECPublicKey ) {
     private void setCurveNameFromPublicKeyIfNeeded() {
         if (curveName == null && publicKey != null) {
             final String oid = getCurveNameObjectIdFromKey(getRuntime(), publicKey);
-            if (isCurveName(oid)) {
-                this.curveName = getCurveName(new ASN1ObjectIdentifier(oid));
+            final Optional<ASN1ObjectIdentifier> curveId = getCurveOID(oid);
+            if (curveId.isPresent()) {
+                this.curveName = getCurveName(curveId.get());
             }
         }
     }