[fix] OpenSSL::X509::Request#version default is -1

jruby · Apr 10, 2024 · 864ea49 · 864ea49
1 parent ad67878
commit 864ea49
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/org/jruby/ext/openssl/X509Request.java b/src/main/java/org/jruby/ext/openssl/X509Request.java
@@ -267,7 +267,7 @@ public IRubyObject version() {
                 return getRuntime().newFixnum( certVersion.intValue() );
             }
         }
-        return version == null ? getRuntime().newFixnum(0) : version;
+        return version == null ? getRuntime().newFixnum(-1) : version;
     }
 
     @JRubyMethod(name="version=")

diff --git a/src/test/ruby/x509/test_x509req.rb b/src/test/ruby/x509/test_x509req.rb
@@ -49,7 +49,7 @@ def test_csr_request_ec_key
 
   def test_version
     csr = OpenSSL::X509::Request.new
-    assert_equal 0, csr.version
+    assert_equal -1, csr.version
 
     req = OpenSSL::X509::Request.new
     req.version = 1