[fix] restoring terminal settings, for good! #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the previous attempt (on runtime tear-down) does not always work towards getting updates back: jruby/jruby#5387 actually also resolves: jruby/jruby#3181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...hopefully
since the previous attempt (on runtime tear-down) does not always work, for reasons I do not comprehend
runtime tear-down is still in.
towards getting updates back: jruby/jruby#5387
its a hammer but this is also what tools such as highline do to work-around JRuby's readline
would release this as 1.4.0