Drop jruby 9.1 support #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should at least allow the jruby-head task to start.
deivid-rodriguez
force-pushed
the
drop_91_support
branch
from
ac398ec to
8be1d87
Compare
|
On jruby 9.2, the
I think this is because https://github.com/torquebox/jruby-maven-plugins does not support jruby 9.2, which seems fixed by the last commit in that repo: jruby/jruby-maven-plugins#106. So ideally, a release of that repo would fix things for us. |
|
Alright, this one should be ready! In addition to dropping support I also added a small fix so that the jruby-head job at least runs, showing that it is broken quite badly 😅. |
|
Agreed, 9.1 is long EOL now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #491.