Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Requester.verify typing to support TLS CA certificate paths #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JannikSt
Copy link

Summary

Updated the type annotation for the verify parameter in the Requester class to support both boolean values and string paths to CA certificates (Union[bool, str]). This aligns with the Python requests library's verification parameter and enables proper mTLS setup with custom CA certificates as documented in Nomad's TLS configuration guide.

Details

  • Changed verify parameter type from bool to Union[bool, str]
  • Maintains backward compatibility with boolean values
  • Enables specifying custom CA certificate paths for TLS verification
  • Follows the same pattern as the requests library's verify parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant