Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kita.js.org #8455

Merged
merged 3 commits into from
Aug 30, 2023
Merged

kita.js.org #8455

merged 3 commits into from
Aug 30, 2023

Conversation

arthurfiorette
Copy link
Contributor

Kita JS

Performant and type safe Fastify router -- Build fast end-to-end APIs with ZERO abstraction cost!

Current documentation still being done. However, product (https://github.com/kitajs/kitajs) is already working and used in production. Waiting approval here to commit CNAME and after finished I'll have to fix current base path to remove the /docs GitHub pages default.

Thanks!

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file labels Aug 22, 2023
@indus
Copy link
Member

indus commented Aug 22, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line kita.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

@arthurfiorette

This comment was marked as outdated.

@arthurfiorette
Copy link
Contributor Author

arthurfiorette commented Aug 22, 2023

Update: I added it to the public folder, which gets in the root artifact when releasing it. Still getting ERR_TOO_MANY_REDIRECTS though.

@indus
Copy link
Member

indus commented Aug 22, 2023

@arthurfiorette we see this issues with workflows more often recently: #8435 (comment)
You may have to contact GitHub support...

@arthurfiorette
Copy link
Contributor Author

Sent a ticket to them. Waiting for response...

@indus
Copy link
Member

indus commented Aug 29, 2023

@arthurfiorette any updates?

@arthurfiorette
Copy link
Contributor Author

arthurfiorette commented Aug 29, 2023

Hey, yes! Its working fine now...

I submitted a support ticket to them, while waiting to them, I manually created a gh-pages branch and was deploying from there... They replied my ticket without any help, saying the deployment was fine (obviously, I moved to a branch). After, I tried to go back to a actions deployment and got it working fine...

Maybe, just deploying from a temporary branch and going back to actions was the fix for this problem...

EDIT: sorry for the miss-click

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Aug 30, 2023
@indus
Copy link
Member

indus commented Aug 30, 2023

Welcome https://kita.js.org
(annoying that there is no definitive answer yet on what needs to be done to make it work)

@indus indus merged commit 120eeb6 into js-org:master Aug 30, 2023
2 checks passed
@arthurfiorette arthurfiorette deleted the arthurfiorette-patch-1 branch August 30, 2023 19:31
@arthurfiorette arthurfiorette mentioned this pull request Nov 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants